Don't count pathless --extern for unused-crate-dependencies warnings #72900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
…arnings `--extern proc_macro` is used to add the proc_macro crate to the extern prelude for all procmacros. In general pathless `--extern` only references sysroot/standard libraries and so should be exempt from unused-crate-dependencies warnings.
|
@bors r+ |
|
📌 Commit 3dd6f2c has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 3, 2020
Rollup of 5 pull requests Successful merges: - rust-lang#72586 (split select into submodules) - rust-lang#72900 (Don't count pathless --extern for unused-crate-dependencies warnings) - rust-lang#72924 (Stabilize `std::io::Buf{Reader, Writer}::capacity`) - rust-lang#72942 (clean up E0641 explanation) - rust-lang#72945 (Updated documentation for Control Flow Guard) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--extern proc_macrois used to add the proc_macro crate to the externprelude for all procmacros. In general pathless
--externonly referencessysroot/standard libraries and so should be exempt from
unused-crate-dependencies warnings.
r? @petrochenkov